[Webkit-unassigned] [Bug 117354] [GStreamer] Don't set state to NULL until element is destroyed

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Sep 2 03:25:19 PDT 2013


--- Comment #9 from Philippe Normand <pnormand at igalia.com>  2013-09-02 03:24:39 PST ---
(From update of attachment 210140)
View in context: https://bugs.webkit.org/attachment.cgi?id=210140&action=review

> Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:291
> +    if (m_readyTimerHandler)
> +        g_source_remove(m_readyTimerHandler);

Shouldn't this be done before m_playBin is cleared? Otherwise the timer might fire with an invalid player pointer?

> Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:413
> +    // See also https://bugzilla.gnome.org/show_bug.cgi?id=117354

That bug seems quite unrelated :)

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list