[Webkit-unassigned] [Bug 114227] Text selected with double-click gets unselected after DOM modification

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=114227





--- Comment #16 from Ryosuke Niwa <rniwa at webkit.org>  2013-10-19 16:25:44 PST ---
(From update of attachment 214671)
View in context: https://bugs.webkit.org/attachment.cgi?id=214671&action=review

> Source/WebCore/editing/FrameSelection.cpp:470
> -        newSelection.setWithoutValidation(base, extent);
> +        if (base != extent)
> +            newSelection.setWithoutValidation(base, extent);
> +        else {
> +            if (m_selection.isBaseFirst())
> +                newSelection.setWithoutValidation(start, end);
> +            else
> +                newSelection.setWithoutValidation(end, start);
> +        }

Looks like we also need to call setIsDirectional here.

> LayoutTests/editing/selection/double-click-selection-with-dom-mutation-expected.txt:3
> +before:

Why is "before" not capitalized?

> LayoutTests/editing/selection/double-click-selection-with-dom-mutation.html:4
> +    <meta charset="utf-8">

Do we really need this?

> LayoutTests/editing/selection/double-click-selection-with-dom-mutation.html:26
> +            if (workaroundPreserveEnd) {            // the original node should contain its original end
> +                newNode.data = container.data.slice(0, offset);
> +                container.deleteData(0, offset);
> +                container.parentNode.insertBefore(newNode, container);
> +            } else {                                // the original node should contain its original beginning

We don't normally align comments like.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.