[Webkit-unassigned] [Bug 122097] ASSERTION FAILED: !style->propertyIsImportant(propertyID) in WebCore::setTextDecorationProperty

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Oct 19 17:36:59 PDT 2013


--- Comment #16 from Ryosuke Niwa <rniwa at webkit.org>  2013-10-19 17:35:44 PST ---
(From update of attachment 214648)
View in context: https://bugs.webkit.org/attachment.cgi?id=214648&action=review

> Source/WebCore/editing/ApplyStyleCommand.cpp:1016
> +    if ((node->renderer()->isRenderBlockFlow() || node->childNodeCount() || node->hasTagName(iframeTag)) && node->isHTMLElement()) {

On my second thought, it might make more sense to simply ignore iframe because adding inline style on iframe should have no effect.
e.g. underlining, bolding, etc… iframe doesn't make any sense since the said inline style won't be applied to the content inside iframe.

Although if iframe's fallback content were to be shown, perhaps…

> LayoutTests/editing/execCommand/remove-format-textdecoration-in-iframe.html:7
> +    document.designMode='on';

Nit: Space around =.

> LayoutTests/editing/execCommand/remove-format-textdecoration-in-iframe.html:8
> +    document.execCommand('selectall');

Why don't we also capitalize SelectAll?

> LayoutTests/editing/execCommand/remove-format-textdecoration-in-iframe.html:15
> +    Markup.dump('container');

Since the style is on body, it doesn't really help to dump the body. Can we add a wrapping node inside body with text-decoration?
If that doesn't work, it might make sense to dump the whole html after removing script elements (to avoid cluttering).

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list