[Webkit-unassigned] [Bug 122097] ASSERTION FAILED: !style->propertyIsImportant(propertyID) in WebCore::setTextDecorationProperty

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=122097





--- Comment #15 from Santosh Mahto <santosh.ma at samsung.com>  2013-10-19 10:24:37 PST ---
ApplyStyleCommand?  The problem here is that even if new text-decoration was empty or some other value, we shouldn't be overriding a property with !important.
> 
> Although we don't do a good job dealing with !important anyway so there is an argument to be made about ignoring !important in some cases.
> 
> Regardless, we need a lot more test cases involing !important in applying & removing inline styles.

I got your concerns. The !important  handling is really debatable here.
Although changes look ok to me (with overriding issue). But really I need to write more test cases covering the inline style handling scenario and to confirm about safety.

Thanks for your points...

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.