[Webkit-unassigned] [Bug 114227] Text selected with double-click gets unselected after DOM modification

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Oct 19 11:33:46 PDT 2013


--- Comment #10 from Ryosuke Niwa <rniwa at webkit.org>  2013-10-19 11:32:31 PST ---
(From update of attachment 214653)
View in context: https://bugs.webkit.org/attachment.cgi?id=214653&action=review

> Source/WebCore/ChangeLog:8
> +        Before this patch When selection is done by double-click(start and base remain

Nit: "When" and "double-click(".

> Source/WebCore/ChangeLog:15
> +        the selection. Since in double-click case start/end contain the
> +        correct selection, same should be used after dom modification to
> +        update selection.

I don't think always using start & end is correct.

> Source/WebCore/ChangeLog:21
> +        (WebCore::FrameSelection::textWasReplaced): use start/end to update
> +        selection

Why is that always correct in cases where selection was not made by double click?

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list