[Webkit-unassigned] [Bug 123448] [GTK] DOM bindings documentation errors

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=123448





--- Comment #3 from Philippe Normand <pnormand at igalia.com>  2013-10-29 09:52:39 PST ---
(In reply to comment #2)
> (From update of attachment 215392 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=215392&action=review
> 
> > Source/WebCore/bindings/gobject/WebKitDOMCustom.h:467
> > + * Returns: A double
> 
> why not a #gdouble?
> 

Because I missed it :)

> > Source/WebCore/bindings/scripts/CodeGeneratorGObject.pm:979
> > +    if (IsGDOMClassType($function->signature->type) && ($returnType ne "void")) {
> 
> can IsGDOMClassType return true for void? 

No.

> In that case I guess we should fix IsGDOMClassType instead.
> 

Thing is IsGDOMClassType doesn't check $returnType. I changed this code only to make sure we don't have a Return tag for void functions. TBH I don't really want to debug this spaghetti code much more :)

> > Source/WebCore/bindings/scripts/CodeGeneratorGObject.pm:982
> > +        push(@hBody, " * Returns: A $returnType\n");
> 
> I think you should check if the type is a glib one to use # so that a link is generated. Also in case of pointers we should remove the *

Ok I'll see if I can improve that...

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.