[Webkit-unassigned] [Bug 123448] [GTK] DOM bindings documentation errors

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=123448





--- Comment #2 from Carlos Garcia Campos <cgarcia at igalia.com>  2013-10-29 09:28:00 PST ---
(From update of attachment 215392)
View in context: https://bugs.webkit.org/attachment.cgi?id=215392&action=review

> Source/WebCore/bindings/gobject/WebKitDOMCustom.h:467
> + * Returns: A double

why not a #gdouble?

> Source/WebCore/bindings/scripts/CodeGeneratorGObject.pm:979
> +    if (IsGDOMClassType($function->signature->type) && ($returnType ne "void")) {

can IsGDOMClassType return true for void? In that case I guess we should fix IsGDOMClassType instead.

> Source/WebCore/bindings/scripts/CodeGeneratorGObject.pm:982
> +        push(@hBody, " * Returns: A $returnType\n");

I think you should check if the type is a glib one to use # so that a link is generated. Also in case of pointers we should remove the *

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.