[Webkit-unassigned] [Bug 122104] [ATK] Expose state of aria-invalid as ATK_STATE_INVALID_ENTRY

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=122104





--- Comment #4 from chris fleizach <cfleizach at apple.com>  2013-10-03 09:50:00 PST ---
(From update of attachment 213251)
View in context: https://bugs.webkit.org/attachment.cgi?id=213251&action=review

> Source/WebCore/accessibility/atk/WebKitAccessibleWrapperAtk.cpp:729
> +    if (!invalidStatus.isEmpty() && invalidStatus != "false")

invalidStatus should never be empty based on previous patch you submitted

> Tools/DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:1045
> +        // If no text attribute was found, just return what the state says.

this comment is not necessary. you're just explaining what the code does rather than why it does it

> Tools/DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:1051
> +        if (isInvalidState != (attributeValue != "false"))

this is a little confusing. maybe split this into to two if/if statements for clarity?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.