[Webkit-unassigned] [Bug 85994] [GStreamer] Seeking fails on media content provided by servers not supporting Range requests

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=85994





--- Comment #62 from Andres Gomez Garcia <agomez at igalia.com>  2013-11-25 04:11:31 PST ---
Thanks a lot for your review!

(In reply to comment #58)
> (From update of attachment 217783 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=217783&action=review
> 
> Awesome work! I just have some minor comments that could be fixed at land time and do not require an extra review process.
> 
> > Source/WebCore/ChangeLog:10
> > +        Properly handle 200 response when doing HTTP range requests.
> 
> Perhaps a bit more detailed explanation needed (what we were doing wrong and how is fixed)

Done.

> > Source/WebCore/platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:863
> > +    if (length > 0 && priv->requestedOffset && 206 == response.httpStatusCode())
> 
> response.httpStatusCode() == 206

Done.

> > Source/WebCore/platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:963
> > +            // If exists, just reset the buffer's offset. Its size will be updated below.
> 
> I'd remove this comment. The code is self-explanatory IMO.

Done.

> > LayoutTests/http/tests/media/media-seeking-no-ranges-server.html:22
> > +            function canplay()
> 
> canPlay()

Done.

> > LayoutTests/http/tests/media/resources/serve-video.php:32
> > +        header("Content-Range: bytes " . $start . "-" . $end . "/" . $fileSize);
> 
> some tab instead of spaces maybe?

No, it was just a correction in the indentation to set it correctly, as in the rest of the file.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.