[Webkit-unassigned] [Bug 85994] [GStreamer] Seeking fails on media content provided by servers not supporting Range requests

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=85994


Carlos Garcia Campos <cgarcia at igalia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #217783|                            |commit-queue-
               Flag|                            |




--- Comment #61 from Carlos Garcia Campos <cgarcia at igalia.com>  2013-11-25 04:09:57 PST ---
(From update of attachment 217783)
View in context: https://bugs.webkit.org/attachment.cgi?id=217783&action=review

>> Source/WebCore/platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:844
>>          return;
> 
> locker.unlock() before return?

No, you don't need to explicitly call unlock in this case, because it will be called by the GMutexLocker destructor. It was called before because webKitWebSrcStop takes the lock too.

> Source/WebCore/platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:945
> +        locker.unlock();

Si, this not needed either.

> Source/WebCore/platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:955
> +            locker.unlock();

Ditto.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.