[Webkit-unassigned] [Bug 124406] [GTK] Mark all deprecated symbols in GObject DOM bindings

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=124406


Gustavo Noronha (kov) <gns at gnome.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #217391|review?                     |review+
               Flag|                            |




--- Comment #3 from Gustavo Noronha (kov) <gns at gnome.org>  2013-11-20 04:07:26 PST ---
(From update of attachment 217391)
View in context: https://bugs.webkit.org/attachment.cgi?id=217391&action=review

LGTM with one minor nit:

> Source/WebCore/bindings/gobject/WebKitDOMDeprecated.cpp:22
> +#if !defined(WEBKIT_DISABLE_DEPRECATED)

I don't think we want this in the implementation file, just on the header, since it's something that should be used only by stuff that use WebKit at build time only.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.