[Webkit-unassigned] [Bug 124406] [GTK] Mark all deprecated symbols in GObject DOM bindings

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=124406





--- Comment #4 from Carlos Garcia Campos <cgarcia at igalia.com>  2013-11-20 08:27:06 PST ---
(In reply to comment #3)
> (From update of attachment 217391 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=217391&action=review
> 
> LGTM with one minor nit:

Thanks for the review.

> > Source/WebCore/bindings/gobject/WebKitDOMDeprecated.cpp:22
> > +#if !defined(WEBKIT_DISABLE_DEPRECATED)
> 
> I don't think we want this in the implementation file, just on the header, since it's something that should be used only by stuff that use WebKit at build time only.

I'm not sure I get it. This is not used internally, when WebKit is built without deprecated symbols we don't want the implementations either, otherwise we will have a bunch of non static methods without a prototype.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.