[Webkit-unassigned] [Bug 124175] Blob constructor should accept sequences

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Nov 12 12:24:20 PST 2013


--- Comment #6 from Victor Costan <costan at gmail.com>  2013-11-12 12:23:02 PST ---
Thank you for the fast and thorough feedback!

toJSSequence() throws a TypeError with no description. I copied its code and tweaked it to do what I wanted.

The two solutions I thought about are:
1) Adding a toJSSequence overload that takes an extra String containing the error description, and changing the current version to call it with the string TypeError.

2) Creating a separate toJSSequenceWithCustomErrorMessage (I'm terrible at names, sorry) with the tweaks that I added there.

Which way would you like me to go?

I inherited the Date / RegExp issue from the original implementation. I know the V8 bindings in Blink explicitly test, and I thought there's some reason why this isn't happening in JavaScriptCore / WebKit. Should I add the checks to toJSSequence?

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list