[Webkit-unassigned] [Bug 124175] Blob constructor should accept sequences

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=124175





--- Comment #7 from Christophe Dumez <dchris at gmail.com>  2013-11-12 12:45:00 PST ---
(In reply to comment #6)
> Thank you for the fast and thorough feedback!
> 
> 
> toJSSequence() throws a TypeError with no description. I copied its code and tweaked it to do what I wanted.
> 
> The two solutions I thought about are:
> 1) Adding a toJSSequence overload that takes an extra String containing the error description, and changing the current version to call it with the string TypeError.
> 
> 2) Creating a separate toJSSequenceWithCustomErrorMessage (I'm terrible at names, sorry) with the tweaks that I added there.

Technically, we don't strictly need this custom error message. Throwing a TypeError is enough, but I'll let Alexey decide.

> Which way would you like me to go?
> 
> I inherited the Date / RegExp issue from the original implementation. I know the V8 bindings in Blink explicitly test, and I thought there's some reason why this isn't happening in JavaScriptCore / WebKit. Should I add the checks to toJSSequence?

This is not really related to this patch then and can / should be addressed separately.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.