[Webkit-unassigned] [Bug 124149] Build fail on CPU(ARM_TRADITIONAL) after r159039
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Nov 11 08:58:04 PST 2013
https://bugs.webkit.org/show_bug.cgi?id=124149
Geoffrey Garen <ggaren at apple.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #216575|review? |review-
Flag| |
--- Comment #2 from Geoffrey Garen <ggaren at apple.com> 2013-11-11 08:56:46 PST ---
(From update of attachment 216575)
It looks like this change will cut back the ARMv7Assembler from max register r15 to max register r13, since ARMv7Assembler::lastRegister() returns r13.
Is that the right thing to do? Your ChangeLog doesn't explain why you did it, or why it's right.
Regardless of whether it's right, it's bad for a build fix patch on one platform to include a behavior change on another platform. They should be two separate patches.
--
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
More information about the webkit-unassigned
mailing list