[Webkit-unassigned] [Bug 124149] Build fail on CPU(ARM_TRADITIONAL) after r159039

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Nov 11 09:12:42 PST 2013


--- Comment #3 from Gabor Rapcsanyi <rgabor at webkit.org>  2013-11-11 09:11:24 PST ---
That's the ARMAssembler not the ARMv7Assembler and it has no effect on it. I just put these functions to the right place form MacroAssemblerARM to ARMAssembler as the other Assemblers work. I don't see how this patch effects on the ARMv7Assembler.

(In reply to comment #2)
> (From update of attachment 216575 [details])
> It looks like this change will cut back the ARMv7Assembler from max register r15 to max register r13, since ARMv7Assembler::lastRegister() returns r13.
> Is that the right thing to do? Your ChangeLog doesn't explain why you did it, or why it's right. 
> Regardless of whether it's right, it's bad for a build fix patch on one platform to include a behavior change on another platform. They should be two separate patches.

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list