[Webkit-unassigned] [Bug 111668] webkitpy: change git_commit_from_svn_revision() to work in a pure git checkout

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=111668





--- Comment #9 from Ryosuke Niwa <rniwa at webkit.org>  2013-11-04 12:28:39 PST ---
(From update of attachment 215920)
View in context: https://bugs.webkit.org/attachment.cgi?id=215920&action=review

>>> Tools/Scripts/webkitpy/common/checkout/scm/git.py:313
>>> +        git_log = self._run_git(['log', '-1', '--grep=' + '^\s*git-svn-id:.*@%s ' % svn_revision])
>> 
>> What's the point of +?
> 
> As mentioned earlier in that file:
> # We use '--grep=' + foo rather than '--grep', foo because
> # git 1.7.0.4 (and earlier) didn't support the separate arg.

I get that but why don't you just do '--grep=^\s*git-svn-id:.*@%s ' instead?  It seems like ' + ' is a useless noise.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.