[Webkit-unassigned] [Bug 111668] webkitpy: change git_commit_from_svn_revision() to work in a pure git checkout

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=111668


Peter Molnar <pmolnar.u-szeged at partner.samsung.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |pmolnar.u-szeged at partner.sa
                   |                            |msung.com




--- Comment #8 from Peter Molnar <pmolnar.u-szeged at partner.samsung.com>  2013-11-04 12:25:04 PST ---
(In reply to comment #7)
> (From update of attachment 215920 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=215920&action=review
> 
> Did you run test-webkitpy webkitpy.common.checkout.scm.scm_unittest?

Yes, in fact I ran "test-webkitpy --all" that covers all SCM tests as far as I know. All webkitpy tests were passing.

> 
> > Tools/Scripts/webkitpy/common/checkout/scm/git.py:313
> > +        git_log = self._run_git(['log', '-1', '--grep=' + '^\s*git-svn-id:.*@%s ' % svn_revision])
> 
> What's the point of +?

As mentioned earlier in that file:
# We use '--grep=' + foo rather than '--grep', foo because
# git 1.7.0.4 (and earlier) didn't support the separate arg.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.