[Webkit-unassigned] [Bug 116096] DOMFileSystemBase: merge BlackBerry implementation
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue May 14 09:58:38 PDT 2013
https://bugs.webkit.org/show_bug.cgi?id=116096
--- Comment #2 from Darin Adler <darin at apple.com> 2013-05-14 09:57:04 PST ---
(From update of attachment 201699)
View in context: https://bugs.webkit.org/attachment.cgi?id=201699&action=review
> Source/WebCore/Modules/filesystem/DOMFileSystemBase.cpp:87
> + KURL originURL(ParsedURLString, url.path());
Is it really OK to parse just the path as a URL and claim it is a “parsed URL string”? What are you trying to accomplish here? How will originURL.path() be different from url.path()?
> Source/WebCore/Modules/filesystem/DOMFileSystemBase.cpp:90
> + if (path.isEmpty() || path[0] != '/')
> + return false;
No need for the path.isEmpty() check here. path[0] will return 0 if the path is empty.
> Source/WebCore/Modules/filesystem/DOMFileSystemBase.cpp:103
> + if (path.isEmpty() || path[0] != '/')
> + return false;
Ditto.
--
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
More information about the webkit-unassigned
mailing list