[Webkit-unassigned] [Bug 116096] DOMFileSystemBase: merge BlackBerry implementation

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue May 14 11:18:32 PDT 2013


--- Comment #3 from Alberto Garcia <agarcia at igalia.com>  2013-05-14 11:16:59 PST ---
(In reply to comment #2)
> > +        KURL originURL(ParsedURLString, url.path());

> Is it really OK to parse just the path as a URL and claim it is a
> “parsed URL string”? What are you trying to accomplish here? How
> will originURL.path() be different from url.path()?

The URL is something like this:


In this case originURL would be file:///temporary/foo
and originURL.path() would be /temporary/foo

> > Source/WebCore/Modules/filesystem/DOMFileSystemBase.cpp:90
> > +        if (path.isEmpty() || path[0] != '/')
> > +            return false;

> No need for the path.isEmpty() check here. path[0] will return 0 if
> the path is empty.

You're right, I'll correct this.

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list