[Webkit-unassigned] [Bug 116049] Add a DisplayAndPowerController class to handle IOKit Display and Power notifications

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=116049





--- Comment #3 from Roger Fong <roger_fong at apple.com>  2013-05-13 21:16:22 PST ---
> I’d call this PowerSavingController instead.

Hmm the display notification functionality is for power saving but the power notifications functionality is for shared timer stuff...plus I feel like the class can be used for more than just PowerSaving functionality in the future right?

> Why do these member functions and variables need to be in this class if they were private?
> Can’t they just be on DisplayAndPowerControllerInternals instead?

They access private variables of DisplayAndPowerController so I stuck them in the class to get around that.

> 
> I’m not sure it’s such a good idea for a function named sharedController to have a side effect…
> Instead of adding a comment above, we should rename it to be more descriptive.
> How about something like init() or createSharedController()?

Hmm okay, I was just following DisplayRefreshMonitorManager::sharedManager(), but perhaps that too is poorly named.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.