[Webkit-unassigned] [Bug 115865] Web Inspector: implement runOpenPanel callback for WebKit2-hosted inspector page

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=115865


Timothy Hatcher <timothy at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #201310|review?                     |review-
               Flag|                            |




--- Comment #5 from Timothy Hatcher <timothy at apple.com>  2013-05-10 04:36:08 PST ---
(From update of attachment 201310)
View in context: https://bugs.webkit.org/attachment.cgi?id=201310&action=review

> Source/WebKit2/UIProcess/mac/WebInspectorProxyMac.mm:237
> +    if (!inspectorWindow)

Sorry, I didn't mean to cause confusion. What you had before was fine. If window is nil (which it is when the Inspector is docked) passing nil to NSOpenPanel will create a modal dialog instead of a sheet. Now with this patch Open does not work when docked. You can remove the ASSERT and early return.

I just wanted you to understand and test the docked vs windowed case and make sure you get what you expect.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.