[Webkit-unassigned] [Bug 115865] Web Inspector: implement runOpenPanel callback for WebKit2-hosted inspector page

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri May 10 09:12:06 PDT 2013


--- Comment #6 from Brian Burg <burg at cs.washington.edu>  2013-05-10 09:10:32 PST ---
(In reply to comment #5)
> (From update of attachment 201310 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=201310&action=review
> > Source/WebKit2/UIProcess/mac/WebInspectorProxyMac.mm:237
> > +    if (!inspectorWindow)
> Sorry, I didn't mean to cause confusion. What you had before was fine. If window is nil (which it is when the Inspector is docked) passing nil to NSOpenPanel will create a modal dialog instead of a sheet. Now with this patch Open does not work when docked. You can remove the ASSERT and early return.
> I just wanted you to understand and test the docked vs windowed case and make sure you get what you expect.

Confusion leads to understanding. :-) In this case, I wasn't aware that behavior would happen with a nil window argument. I couldn't find any documentation of what happens with nil window (seems I'm not the only one: http://stackoverflow.com/questions/671204/why-isnt-my-sheet-attached-to-the-window-its-run-for?rq=1).

I'll revert that guard, add a comment to document the intended modal behaviors, and test on a bigger screen.

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list