[Webkit-unassigned] [Bug 115781] [BlackBerry] Fix usage of BlackBerry::Platform::String

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed May 8 02:10:21 PDT 2013


Benjamin Poulain <benjamin at webkit.org> changed:

           What    |Removed                     |Added
 Attachment #201044|review?, commit-queue?      |review-, commit-queue-
               Flag|                            |

--- Comment #2 from Benjamin Poulain <benjamin at webkit.org>  2013-05-08 02:08:45 PST ---
(From update of attachment 201044)
View in context: https://bugs.webkit.org/attachment.cgi?id=201044&action=review

> Source/WebKit/blackberry/Api/WebSettings.cpp:209
> +    DEFINE_STATIC_LOCAL(AtomicString, WebKitMonospace, ("-webkit-monospace"));
> +    DEFINE_STATIC_LOCAL(AtomicString, WebKitSansSerif, ("-webkit-sans-serif"));
> +    DEFINE_STATIC_LOCAL(AtomicString, WebKitSerif, ("-webkit-serif"));
> +    DEFINE_STATIC_LOCAL(AtomicString, WebKitStandard, ("-webkit-standard"));

Given that "settings" is static local, you will never hit this path again. Why would you define those static?

It also looks like your "WebSettings" class takes a String, not an AtomicString.

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list