[Webkit-unassigned] [Bug 115781] [BlackBerry] Fix usage of BlackBerry::Platform::String

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=115781





--- Comment #3 from Arvid Nilsson <anilsson at rim.com>  2013-05-08 02:38:47 PST ---
(In reply to comment #2)
> (From update of attachment 201044 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=201044&action=review
> 
> > Source/WebKit/blackberry/Api/WebSettings.cpp:209
> > +    DEFINE_STATIC_LOCAL(AtomicString, WebKitMonospace, ("-webkit-monospace"));
> > +    DEFINE_STATIC_LOCAL(AtomicString, WebKitSansSerif, ("-webkit-sans-serif"));
> > +    DEFINE_STATIC_LOCAL(AtomicString, WebKitSerif, ("-webkit-serif"));
> > +    DEFINE_STATIC_LOCAL(AtomicString, WebKitStandard, ("-webkit-standard"));
> 
> Given that "settings" is static local, you will never hit this path again. Why would you define those static?
> 
> It also looks like your "WebSettings" class takes a String, not an AtomicString.

One possible reasoning behind this could be:
"-webkit-monospace" will be added into the AtomicString table sooner or later anyway, or could already be in the table at this point.
That depends on if/how -webkit-monospace is used down in WebCore.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.