[Webkit-unassigned] [Bug 105156] [EFL] Process launcher uses system() for wrapping the WebProcess when using WEB_PROCESS_CMD_PREFIX

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=105156





--- Comment #6 from Mikhail Pozdnyakov <mikhail.pozdnyakov at intel.com>  2013-05-03 00:29:56 PST ---
(From update of attachment 200383)
View in context: https://bugs.webkit.org/attachment.cgi?id=200383&action=review

> Source/WebKit2/ChangeLog:3
> +        [EFL][WK2] ProcessLauncher: do not handle WEB_PROCESS_CMD_PREFIX with system()

Seems that the actual bug has another title.

> Source/WebKit2/UIProcess/Launcher/efl/ProcessLauncherEfl.cpp:40
> +    ProcessExecArgs(String cmd)

const String&

> Source/WebKit2/UIProcess/Launcher/efl/ProcessLauncherEfl.cpp:46
> +        cmd.split(' ', args);

so you've composed this string before in ProcessLauncher::launchProcess(), and now you're decomposing it again..

> Source/WebKit2/UIProcess/Launcher/efl/ProcessLauncherEfl.cpp:67
> +    char* const* args() { return const_cast<char* const*>(m_argv); }

why not const char* ?

> Source/WebKit2/UIProcess/Launcher/efl/ProcessLauncherEfl.cpp:71
> +    Vector<CString> m_splitArgs;

why is that needed?

> Source/WebKit2/UIProcess/Launcher/efl/ProcessLauncherEfl.cpp:98
> +    String fullCmd = String::fromUTF8(executablePath.data()) + ' ' + String::number(sockets[0]) + ' ' + String::fromUTF8(pluginPath.data());

I'd consider using of StringBuilder

> Source/WebKit2/UIProcess/Launcher/efl/ProcessLauncherEfl.cpp:103
> +    ProcessExecArgs execArgs(fullCmd);

why do you need a class here? seems a function would be enough

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.