[Webkit-unassigned] [Bug 115495] Web Inspector: Fix check-inspector-strings script and fix localized strings

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed May 1 16:40:42 PDT 2013


Joseph Pecoraro <joepeck at webkit.org> changed:

           What    |Removed                     |Added
 Attachment #200251|review?                     |review-
               Flag|                            |

--- Comment #2 from Joseph Pecoraro <joepeck at webkit.org>  2013-05-01 16:39:04 PST ---
(From update of attachment 200251)
View in context: https://bugs.webkit.org/attachment.cgi?id=200251&action=review

The update to the tool seems good. But seems like some issues with the updated strings file.

> Source/WebCore/English.lproj/localizedStrings.js:-623
> -localizedStrings["Filter"] = "Filter";

I still see this in ConsoleView.js. Was this a duplicate entry?

468:        var filterSubMenu = contextMenu.appendSubMenuItem(WebInspector.UIString("Filter"));

> Source/WebCore/English.lproj/localizedStrings.js:936
> +localizedStrings["Number of calls"] = "Self time";

This doesn't look right. "Number of calls" should be "Number of calls".

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list