[Webkit-unassigned] [Bug 115495] Web Inspector: Fix check-inspector-strings script and fix localized strings

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed May 1 16:48:05 PDT 2013


https://bugs.webkit.org/show_bug.cgi?id=115495





--- Comment #3 from Seokju Kwon <seokju.kwon at gmail.com>  2013-05-01 16:46:28 PST ---
(In reply to comment #2)
> (From update of attachment 200251 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=200251&action=review
> 
> The update to the tool seems good. But seems like some issues with the updated strings file.
> 
> > Source/WebCore/English.lproj/localizedStrings.js:-623
> > -localizedStrings["Filter"] = "Filter";
> 
> I still see this in ConsoleView.js. Was this a duplicate entry?
> 
Yes, It was a dulpicate entry. And I remove one of two "Filter".
(205 : localizedStrings["Filter"] = "Filter";)

> ConsoleView.js
> 468:        var filterSubMenu = contextMenu.appendSubMenuItem(WebInspector.UIString("Filter"));
> 
> > Source/WebCore/English.lproj/localizedStrings.js:936
> > +localizedStrings["Number of calls"] = "Self time";
> 
> This doesn't look right. "Number of calls" should be "Number of calls".

Oops, I will fix it.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list