[Webkit-unassigned] [Bug 109884] Add CSS Property tracking to FeatureObserver. Creates new histogram for CSS Property usage data.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=109884





--- Comment #28 from Mike Lawther <mikelawther at chromium.org>  2013-03-25 19:34:47 PST ---
(In reply to comment #22)
> I'm not a huge fan of adding another switch statement that we need to update every time we add/remove a CSS property. The switch statement is fine, but lets only put the properties in this switch statement that we actually care to measure. Specifically, lets just put the WebKit prefixed properties for now since those are the properties we'd like to kill if they have sufficiently low usage.

Yeah, we went back and forth on this one.  We do want to track all properties, not just prefixed ones.

The alternative we considered was to map everything post-facto on the dashboard side, involving using the existing CSSProperty enum values, knowing what version of WebKit the features were from, checking that out from source control and reconciling the enum values with property names etc. It sounded like a good idea at the time, but when we looked at implementing it For Reals, it was becoming pretty brittle.

We discussed this with abarth, and he said that doing dashboard side might be easier (it turned out not to be :( ), and that he was OK with the WebKit-side mapping approach if we thought it best. The UMA team were also pretty set on having a stable ID come through the pipeline (ie map WebKit side).

I can't think of a better way to automatically get tracking of all CSS properties. It's a huge boring 1:1 mapping at the moment, but is pretty future proof. What do you reckon?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.