[Webkit-unassigned] [Bug 109884] Add CSS Property tracking to FeatureObserver. Creates new histogram for CSS Property usage data.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=109884





--- Comment #27 from Kassy Coan <kassycoan at gmail.com>  2013-03-25 19:31:34 PST ---
(In reply to comment #26)
> (In reply to comment #22)
> > (From update of attachment 194779 [details] [details])
> > View in context: https://bugs.webkit.org/attachment.cgi?id=194779&action=review
> > 
> > > Source/WebCore/css/CSSParser.cpp:1327
> > > +    FeatureObserver::observe(m_context.m_document.get(), propertyID);
> > 
> > Don't we crash if you use a parser context created with the two argument constructor?
> 
> New patch addresses this.

My understanding is RefPtr.get() returns 0 if the parser context m_document is 0, and there is a check in FeatureObserver::observe() to early return if the given document is 0.  So, I don't believe we can crash.

If this is correct, perhaps we should code for the common case (the document exists) instead of doing a if(m_context.m_document) check every time before we call FeatureObserver::observe()?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.