[Webkit-unassigned] [Bug 111714] [GTK][Regression] webkit_dom_html_table_element_insert_row returns value that doesn't pass WEBKIT_DOM_IS_HTML_TABLE_ROW_ELEMENT macro

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=111714





--- Comment #10 from Carlos Garcia Campos <cgarcia at igalia.com>  2013-03-23 11:25:13 PST ---
(In reply to comment #8)
> (In reply to comment #4)
> > This patch is a simple workaround to cover the HTML elements case, so that we can apply it to the stable branch before releasing without much risk. But the real problem affects all polymorphic objects and requires a lot more work. See bug #113132.
> 
> As we have discussed at length I don't see the point of doing a patch that purely fixes the HTMLElement case, since all HTMLElement subclasses are also broken.
> 
> As I suggested I think the simple fix for the stable branch is to change the ::kit implementation in CodeGeneratorGObject for all HTMLElement subclasses (including HTMLElement itself) to do what your patch does only for HTMLElement. This is obviously correct and IMHO low risk, and fixes a giant bug that we should not have in 2.0.

I used the approach I thought it had the lowest risk to be applied in the stable branch two days before the release.

> What we can do after 2.0 is fix the completely general case, which would be still broken with the patch I suggest.

It has always been broken and nobody has noticed it until now, so I don't think it's that important. We can fix the general case in master and try it out for a while, so that when we are sure it works fine, we can merge it into the stable branch for 2.0.1.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.