[Webkit-unassigned] [Bug 111714] [GTK][Regression] webkit_dom_html_table_element_insert_row returns value that doesn't pass WEBKIT_DOM_IS_HTML_TABLE_ROW_ELEMENT macro

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=111714





--- Comment #11 from Carlos Garcia Campos <cgarcia at igalia.com>  2013-03-23 11:27:09 PST ---
(In reply to comment #9)
> A few more comments after grepping some code:
> 
> - I think the only case where we have intermediate HTMLElement subclasses that could trigger this bug is HTMLMediaElement subclasses (Audio and Video element). So adding those to the manually generated ::kit methods would be enough, but I think is a must for 2.0 (in fact they can just proxy HTMLElement, which IMHO should also just proxy Element).
> 
> - Our Node ::kit method just calls createWrapper, which in turn just does the right thing for Element, HTMLElement, etc, so all our manual ::kit implementations can be reduced to just this one method IMHO.
> 
> Depending on the amount on non Node objects we ship it might be easier to just have a manual list of those and give everything else a ::kit method like the one we use in Node right now, but we can discuss that in the other bug.

See my patch in the other bug, it uses a different approach based on having a kit method for all objects and some custom wrap methods, more similar to what Objc bindings do.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.