[Webkit-unassigned] [Bug 111094] [Qt]clearMemoryCaches of QWebSettings should call GC to release references of CachedResource

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Mar 1 00:34:22 PST 2013


Simon Hausmann <hausmann at webkit.org> changed:

           What    |Removed                     |Added
 Attachment #190772|review?                     |review-
               Flag|                            |

--- Comment #3 from Simon Hausmann <hausmann at webkit.org>  2013-03-01 00:36:46 PST ---
(From update of attachment 190772)
View in context: https://bugs.webkit.org/attachment.cgi?id=190772&action=review

It sounds to me that this is a reasonable thing to do. Allan, what do you think?

(r- because of #ifdefs that aren't needed)

> Source/WebKit/qt/Api/qwebsettings.cpp:49
> +#if USE(JSC)
> +#include "GCController.h"
> +#else    
> +#include "V8GCController.h"
> +#endif

We don't support v8 as underlying JS engine at this point, so I suggest to remove the USE(JSC) and just use it directly.

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list