[Webkit-unassigned] [Bug 111094] [Qt]clearMemoryCaches of QWebSettings should call GC to release references of CachedResource

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=111094





--- Comment #21 from Allan Sandfeld Jensen <allan.jensen at digia.com>  2013-03-06 06:42:58 PST ---
(From update of attachment 191508)
View in context: https://bugs.webkit.org/attachment.cgi?id=191508&action=review

> Source/WebKit/qt/Api/qwebsettings.cpp:853
> +    // Garbage Collect to release the references of CachedResource from dead objects
> +    WebCore::gcController().garbageCollectNow();

You don't need to call garbageCollect when you call discardAllCompiledCode. It does that as well.

> Source/WebKit/qt/Api/qwebsettings.cpp:868
> +    // FastMalloc has lock-free thread specific caches that can only be cleared from the thread itself.
> +    WebCore::StorageThread::releaseFastMallocFreeMemoryInAllThreads();
> +#if ENABLE(WORKERS)
> +    WebCore::WorkerThread::releaseFastMallocFreeMemoryInAllThreads();
> +#endif
> +#if ENABLE(THREADED_SCROLLING)
> +    WebCore::ScrollingThread::dispatch(bind(WTF::releaseFastMallocFreeMemory));
> +#endif
> +    WTF::releaseFastMallocFreeMemory();    

I would skip these for now. They are not really caches, and we also don't support scrolling threads.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.