[Webkit-unassigned] [Bug 108370] Some spellcheck tests require asynchronous spellcheck

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=108370





--- Comment #16 from Rouslan Solomakhin <rouslan+webkit at chromium.org>  2013-03-04 16:26:16 PST ---
(In reply to comment #15)
> (From update of attachment 191329 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=191329&action=review
> 
> It would be better to split this into 2 patches: 1 patch that refactors sync and async to share code and 1 patch to change the tests.  It's hard to read the diff due to code moving around.

Sounds good. I will split up the patch.


> > Tools/DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:232
> > +    bindMethod("setContinuousSpellCheckingEnabled", &TestRunner::setContinuousSpellCheckingEnabled);
> 
> We should implement this in Internals.{h,cpp,idl} so all the ports can share this.  Maybe we should do a patch to move setAsynchronousSpellCheckingEnabled to Internals first.

Ryosuke: Would you be okay with moving setAsynchronousSpellCheckingEnabled and setContinuousSpellCheckingEnabled to Internals?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.