[Webkit-unassigned] [Bug 108370] Some spellcheck tests require asynchronous spellcheck

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Mar 4 16:19:20 PST 2013


Tony Chang <tony at chromium.org> changed:

           What    |Removed                     |Added
 Attachment #191329|review?                     |review-
               Flag|                            |

--- Comment #15 from Tony Chang <tony at chromium.org>  2013-03-04 16:21:44 PST ---
(From update of attachment 191329)
View in context: https://bugs.webkit.org/attachment.cgi?id=191329&action=review

It would be better to split this into 2 patches: 1 patch that refactors sync and async to share code and 1 patch to change the tests.  It's hard to read the diff due to code moving around.

> Tools/DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:232
> +    bindMethod("setContinuousSpellCheckingEnabled", &TestRunner::setContinuousSpellCheckingEnabled);

We should implement this in Internals.{h,cpp,idl} so all the ports can share this.  Maybe we should do a patch to move setAsynchronousSpellCheckingEnabled to Internals first.

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list