[Webkit-unassigned] [Bug 110291] Move WebCore feature defines to the WebCore directory

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=110291





--- Comment #13 from Mark Hahnenberg <mhahnenberg at apple.com>  2013-03-03 09:08:31 PST ---

> This is already defined in JSBase.h.  It should definitely not move to WebCore, and should probably just be removed from FeatureDefines.h (separate from this effort) since JSBase.h should be included wherever JSC_OBJC_API_ENABLED is used.  Tracking down a build failure because JSC_OBJC_API_ENABLED was defined differently in two places (and not knowing it was defined in FeatureDefines.h) required a lot of time.

This flag was originally added to FeatureDefines.h so that it could be used in WebCore.exp.in to determine whether or not we should be exporting certain symbols based on whether the WebKit-related portion of the JSC ObjC API was enabled, but it turned out conditionally including certain symbols didn't work when building fat binaries, so it's not even necessary any more.

tl;dr: removing JSC_OBJC_API_ENABLED from FeatureDefines.h is a good idea.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.