[Webkit-unassigned] [Bug 110291] Move WebCore feature defines to the WebCore directory

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Mar 3 04:37:00 PST 2013


--- Comment #12 from David Kilzer (:ddkilzer) <ddkilzer at webkit.org>  2013-03-03 04:39:22 PST ---
(From update of attachment 191065)
View in context: https://bugs.webkit.org/attachment.cgi?id=191065&action=review

> Source/WebCore/WebCoreFeatureDefines.h:574
> +#if !defined(JSC_OBJC_API_ENABLED)
> +#define JSC_OBJC_API_ENABLED (defined(__clang__) && defined(__APPLE__) && defined(__MAC_OS_X_VERSION_MIN_REQUIRED) && __MAC_OS_X_VERSION_MIN_REQUIRED >= 1090 && !defined(__i386__))
> +#endif

This is already defined in JSBase.h.  It should definitely not move to WebCore, and should probably just be removed from FeatureDefines.h (separate from this effort) since JSBase.h should be included wherever JSC_OBJC_API_ENABLED is used.  Tracking down a build failure because JSC_OBJC_API_ENABLED was defined differently in two places (and not knowing it was defined in FeatureDefines.h) required a lot of time.

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list