[Webkit-unassigned] [Bug 110612] Enumerating an HTMLCollection needs to enumerate the named properties

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Mar 1 17:34:56 PST 2013


--- Comment #11 from Ryosuke Niwa <rniwa at webkit.org>  2013-03-01 17:37:20 PST ---
(From update of attachment 191082)
View in context: https://bugs.webkit.org/attachment.cgi?id=191082&action=review

The patch looks much better. I'll wait 'til JSC/V8 binding experts can comment on this patch.

> Source/WebCore/html/HTMLCollection.cpp:734
> +        if (!propertyNameStrings.contains(attributeValue))

m_nameCache is a hash map, right? Why do we need to check contains?

> Source/WebCore/html/HTMLCollection.cpp:739
> +        if (!propertyNameStrings.contains(attributeValue))


> Source/WebCore/html/HTMLCollection.h:70
> +    void getPropertyNames(Vector<String>& propertyNameStrings);

Should we make this virtual?

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list