[Webkit-unassigned] [Bug 110612] Enumerating an HTMLCollection needs to enumerate the named properties

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=110612





--- Comment #12 from Arko Saha <arko at motorola.com>  2013-03-01 17:57:56 PST ---
(In reply to comment #11)
> > Source/WebCore/html/HTMLCollection.cpp:734
> > +        if (!propertyNameStrings.contains(attributeValue))
> 
> m_nameCache is a hash map, right? Why do we need to check contains?
> 

Yes you are right, this check is not required. Will remove the check.

> > Source/WebCore/html/HTMLCollection.h:70
> > +    void getPropertyNames(Vector<String>& propertyNameStrings);
> 
> Should we make this virtual?

Will do.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.