[Webkit-unassigned] [Bug 118445] [Qt] QtWebKit should allow sending domain specific keycode to HTML applications

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=118445





--- Comment #30 from Jocelyn Turcotte <jocelyn.turcotte at digia.com>  2013-07-29 09:51:55 PST ---
(From update of attachment 207542)
View in context: https://bugs.webkit.org/attachment.cgi?id=207542&action=review

> Source/WebKit/qt/Api/qwebsettings.cpp:515
> +        when Qt::Key to DOM key converstion fails. It might be useful for sending domain specific key values

"when Qt::Key to DOM key converstion fails" is false isn't it? It seems like this will be triggered only if the key is 0.

> Source/WebKit/qt/WebCoreSupport/QWebPageAdapter.cpp:1244
> -    return frame->eventHandler()->keyEvent(ev);
> +    return frame->eventHandler()->keyEvent(PlatformKeyboardEvent(ev, settings->testAttribute(QWebSettings::UseNativeVirtualKeyAsDOMKey)));

I think this is quite messy to be honest.
Do we need the setting? What would you think about simply passing the nativeVirtualKey as well to windowsKeyCodeForKeyEvent, which would fall back to the nativeVirtualKey if the keycode is 0?

I don't see any use case where a 0 key to a QKeyEvent is expected, so this could allow to shape legacy web key events.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.