[Webkit-unassigned] [Bug 119075] With frame flattening on, too many resize events fired if document is resized in onresize handler.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=119075


Simon Fraser (smfr) <simon.fraser at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #207557|review?                     |review+
               Flag|                            |




--- Comment #4 from Simon Fraser (smfr) <simon.fraser at apple.com>  2013-07-26 17:02:25 PST ---
(From update of attachment 207557)
View in context: https://bugs.webkit.org/attachment.cgi?id=207557&action=review

> Source/WebCore/ChangeLog:8
> +        With http://trac.webkit.org/changeset/149287, WebCore also send resize event in FrameView::setFrameRect.  When

sends

> Source/WebCore/ChangeLog:12
> +        is done layout.

is done laying out

> Source/WebCore/page/FrameView.h:441
> +    void setResizeEventAllowed(bool resizeEventAllowed) { m_resizeEventAllowed = resizeEventAllowed; }

Might as well add a const inline setter for this too.

This currently doesn't allow nesting. Does it need to (using a counter)?

> Source/WebCore/rendering/RenderFrameBase.cpp:68
> +    childFrameView->setResizeEventAllowed(false);

Could TemporaryChange<> help you here?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.