[Webkit-unassigned] [Bug 119075] With frame flattening on, too many resize events fired if document is resized in onresize handler.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=119075





--- Comment #5 from Yongjun Zhang <yongjun_zhang at apple.com>  2013-07-26 17:15:54 PST ---
(In reply to comment #4)
> (From update of attachment 207557 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=207557&action=review

> > Source/WebCore/page/FrameView.h:441
> > +    void setResizeEventAllowed(bool resizeEventAllowed) { m_resizeEventAllowed = resizeEventAllowed; }
> 
> Might as well add a const inline setter for this too.

Did you mean getter?  I will add it.

> 
> This currently doesn't allow nesting. Does it need to (using a counter)?
> 
> > Source/WebCore/rendering/RenderFrameBase.cpp:68
> > +    childFrameView->setResizeEventAllowed(false);
> 
> Could TemporaryChange<> help you here?
Seems like if the method and member variable is in the same class, TemporaryChange<> would work.  In this patch, the method and member variable are from different classes.

thanks for the review.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.