[Webkit-unassigned] [Bug 118306] [WTR] Should dump as text when the mimetype is text/plain

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jul 23 05:54:52 PDT 2013


https://bugs.webkit.org/show_bug.cgi?id=118306





--- Comment #30 from Christophe Dumez <dchris at gmail.com>  2013-07-23 05:54:43 PST ---
(From update of attachment 207323)
View in context: https://bugs.webkit.org/attachment.cgi?id=207323&action=review

> Tools/WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:876
> +    WTF::String url = toWTFString(adoptWK(WKURLCopyString(urlRef.get())));

I don't believe WTF:: is needed.

> Tools/WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:877
> +    WTF::String mimeType = toWTFString(adoptWK(WKBundleFrameCopyMIMETypeForResourceWithURL(frame, urlRef.get())));

We don't really need a WTF String here. We can keep it as a WKRetainPtr<WKStringRef> and use WKStringIsEqualToUTF8CString(mimeType.get(), "text/plain") in the if condition.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.


More information about the webkit-unassigned mailing list