[Webkit-unassigned] [Bug 118306] [WTR] Should dump as text when the mimetype is text/plain

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=118306





--- Comment #31 from Peter Gal <galpeter at inf.u-szeged.hu>  2013-07-23 06:39:02 PST ---
(In reply to comment #30)
> (From update of attachment 207323 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=207323&action=review
> 
> > Tools/WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:876
> > +    WTF::String url = toWTFString(adoptWK(WKURLCopyString(urlRef.get())));
> 
> I don't believe WTF:: is needed.
> 

Hmm.. it seems to be true. I just automatically assumed we need that, it's used that way in this file everywhere.

> > Tools/WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:877
> > +    WTF::String mimeType = toWTFString(adoptWK(WKBundleFrameCopyMIMETypeForResourceWithURL(frame, urlRef.get())));
> 
> We don't really need a WTF String here. We can keep it as a WKRetainPtr<WKStringRef> and use WKStringIsEqualToUTF8CString(mimeType.get(), "text/plain") in the if condition.

Didn't know there is function for this. I'll update the patch accordingly.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.