[Webkit-unassigned] [Bug 118970] [Web Inspector] When right-clicking on a DataGrid column, show editing menu option as "Edit <columnName>" instead of just "Edit"

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Jul 22 07:53:05 PDT 2013


https://bugs.webkit.org/show_bug.cgi?id=118970


Antoine Quint <graouts at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #207247|review?                     |review+
               Flag|                            |




--- Comment #3 from Antoine Quint <graouts at apple.com>  2013-07-22 07:52:58 PST ---
(From update of attachment 207247)
View in context: https://bugs.webkit.org/attachment.cgi?id=207247&action=review

> Source/WebInspectorUI/UserInterface/DataGrid.js:1111
> +        function getColumnIdentifier(node) {
> +            var element = node.enclosingNodeOrSelfWithNodeName("td");
> +            return parseInt(element.className.match(/\b(\d+)-column\b/)[1], 10);
> +        }

I think it's a little overkill to add this inline function which is only used once.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.


More information about the webkit-unassigned mailing list