[Webkit-unassigned] [Bug 118970] [Web Inspector] When right-clicking on a DataGrid column, show editing menu option as "Edit <columnName>" instead of just "Edit"

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Jul 22 08:00:24 PDT 2013


https://bugs.webkit.org/show_bug.cgi?id=118970


Timothy Hatcher <timothy at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #207247|review+                     |review-
               Flag|                            |




--- Comment #4 from Timothy Hatcher <timothy at apple.com>  2013-07-22 08:00:17 PST ---
(From update of attachment 207247)
View in context: https://bugs.webkit.org/attachment.cgi?id=207247&action=review

> Source/WebInspectorUI/ChangeLog:9
> +        * Localizations/en.lproj/localizedStrings.js: Add literal "Edit '%s'"

If you didn't, you should use the update-webkit-localized-strings script, which will update this file for you.

> Source/WebInspectorUI/UserInterface/DataGrid.js:1128
> +                    contextMenu.appendItem(WebInspector.UIString("Edit '%s'").format(columnTitle), this._startEditing.bind(this, event.target));

This should use double curly quotes (“”) and not single quotes.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.


More information about the webkit-unassigned mailing list