[Webkit-unassigned] [Bug 118687] Make WebVTTParser return cue data instead of cue DOM objects

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jul 16 11:51:42 PDT 2013


https://bugs.webkit.org/show_bug.cgi?id=118687





--- Comment #11 from Eric Carlson <eric.carlson at apple.com>  2013-07-16 11:51:45 PST ---
(From update of attachment 206796)
View in context: https://bugs.webkit.org/attachment.cgi?id=206796&action=review

> Source/WebCore/html/track/InbandTextTrack.cpp:108
> +        m_genericDataToCueMap.remove(genericData);
> +        m_genericCueToDataMap.remove(cue);

Can't you return here and avoid the call to findWebVTTData() (which will fail anyway)?

> Source/WebCore/html/track/InbandTextTrack.cpp:316
> +    UNUSED_PARAM(trackPrivate);
> +    ASSERT(trackPrivate == m_private);

I think you can use "ASSERT_UNUSED(trackPrivate, trackPrivate == m_private)" here.

> Source/WebCore/html/track/InbandTextTrack.h:69
> +    GenericCueToCueDataMap m_genericCueToDataMap;
> +    GenericCueDataToCueMap m_genericDataToCueMap;
> +    CueToWebVTTCueDataMap m_webVTTCueToDataMap;
> +    WebVTTCueDataToCueMap m_webVTTDataToCueMap;

A track will never have more than one type of cue so we will only ever use two of these. Can they be explicitly allocated?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.


More information about the webkit-unassigned mailing list