[Webkit-unassigned] [Bug 118687] Make WebVTTParser return cue data instead of cue DOM objects

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=118687





--- Comment #12 from Brendan Long <b.long at cablelabs.com>  2013-07-16 12:46:21 PST ---
(In reply to comment #11)
> (From update of attachment 206796 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=206796&action=review
> 
> > Source/WebCore/html/track/InbandTextTrack.cpp:108
> > +        m_genericDataToCueMap.remove(genericData);
> > +        m_genericCueToDataMap.remove(cue);
> 
> Can't you return here and avoid the call to findWebVTTData() (which will fail anyway)?

That makes sense.

> > Source/WebCore/html/track/InbandTextTrack.cpp:316
> > +    UNUSED_PARAM(trackPrivate);
> > +    ASSERT(trackPrivate == m_private);
> 
> I think you can use "ASSERT_UNUSED(trackPrivate, trackPrivate == m_private)" here.

Cool, I didn't know about that macro.

> A track will never have more than one type of cue so we will only ever use two of these. Can they be explicitly allocated?

How? I tried making it a RefPtr<HashMap<...> >, but HashMap doesn't implement RefCounted.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.