[Webkit-unassigned] [Bug 118306] [WTR] Should dump as text when the mimetype is text/plain

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=118306


Christophe Dumez <dchris at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #205918|review?, commit-queue?      |review-, commit-queue-
               Flag|                            |




--- Comment #5 from Christophe Dumez <dchris at gmail.com>  2013-07-03 05:03:04 PST ---
(From update of attachment 205918)
View in context: https://bugs.webkit.org/attachment.cgi?id=205918&action=review

Please unskip tests in the same patch.

> Tools/WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:876
> +    WTF::String mimeType = toWTFString(adoptWK(WKBundleFrameCopyMIMETypeForResourceWithURL(frame, WKBundleFrameCopyURL(frame))));

This is leaking the return value of WKBundleFrameCopyURL().

> Tools/WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:877
> +    if (url.find("dumpAsText/") != WTF::notFound || mimeType == "text/plain")

Don't you mean "&& mimeType != "text/plain" ?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.